Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(UI): script to register at viewer has to require viewer #558

Merged
merged 1 commit into from
May 14, 2024
Merged

fix(UI): script to register at viewer has to require viewer #558

merged 1 commit into from
May 14, 2024

Conversation

blizzz
Copy link
Member

@blizzz blizzz commented May 14, 2024

  • Target version: main

Summary

avoids conditions where registering is attempted when OCA.Viewer is not established yet

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Documentation (manuals or wiki) has been updated or is not required

@blizzz blizzz requested a review from juliushaertl May 14, 2024 10:16
@blizzz blizzz added the 3. to review Waiting for reviews label May 14, 2024
@blizzz
Copy link
Member Author

blizzz commented May 14, 2024

@juliushaertl we discussed the problem i was facing yesterday. with this change, i can open documents properly now on the dev setup.

juliushaertl
juliushaertl reviewed May 14, 2024
View reviewed changes
Copy link
Member

@juliushaertl juliushaertl left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably rather make use of nextcloud/server#30015 and add viewer as 3rd parameter to https://github.com/nextcloud/officeonline/blob/main/lib/Listener/LoadViewerListener.php#L13 so that the officeonline script is only loaded after viewer has been.

@blizzz
Copy link
Member Author

blizzz commented May 14, 2024

We should probably rather make use of nextcloud/server#30015 and add viewer as 3rd parameter to https://github.com/nextcloud/officeonline/blob/main/lib/Listener/LoadViewerListener.php#L13 so that the officeonline script is only loaded after viewer has been.

Cool. Did not know we have that.

@blizzz
fix(UI): script to register at viewer has to require viewer
6202017 
avoids conditions where registering is attempted when OCA.Viewer is not
established yet

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
@blizzz
Copy link
Member Author

blizzz commented May 14, 2024

Changed the PR accordingly.

@blizzz blizzz changed the title fix(UI): wait until content is loaded before registering at OCA.Viewer fix(UI): script to register at viewer has to require viewer May 14, 2024
@juliushaertl juliushaertl merged commit 990e09f into main May 14, 2024
27 checks passed
@juliushaertl juliushaertl deleted the fix/noid/what-for-viewer branch May 14, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliushaertl juliushaertl juliushaertl approved these changes

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blizzz @juliushaertl